Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use React.Fragment as default textComponent #1326

Merged
merged 6 commits into from
Jun 19, 2019
Merged

feat: Use React.Fragment as default textComponent #1326

merged 6 commits into from
Jun 19, 2019

Conversation

longlho
Copy link
Member

@longlho longlho commented Jun 19, 2019

- Fix some `any` casting
- Fix tests
@longlho longlho requested a review from redonkulus June 19, 2019 00:38
@redonkulus
Copy link
Member

FYI the convo from the open issue and linked issues #987

@longlho
Copy link
Member Author

longlho commented Jun 19, 2019 via email

@redonkulus
Copy link
Member

It’s a large change for users. If we want to do this, we should mention how they can keep the span in the upgrade guide.

@longlho
Copy link
Member Author

longlho commented Jun 19, 2019

done

@longlho longlho merged commit 6e03fa3 into master Jun 19, 2019
@longlho longlho deleted the fragment branch June 19, 2019 13:17
@slorber
Copy link

slorber commented Jun 19, 2019

awesome :) please ping when there is a release

@marcesengel
Copy link
Collaborator

@longlho if we decide to do #1330, do you agree we should make this the default over React.Fragment?

@longlho
Copy link
Member Author

longlho commented Jun 20, 2019

yup wait sorry no, bc of RN

@longlho longlho added this to the v3.0.0 milestone Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormattedMessage tagName propTypes should accept React.Fragment
4 participants