Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support textComponent="", fixes #1330 #1354

Merged
merged 1 commit into from
Jul 7, 2019
Merged

feat: support textComponent="", fixes #1330 #1354

merged 1 commit into from
Jul 7, 2019

Conversation

longlho
Copy link
Member

@longlho longlho commented Jul 7, 2019

No description provided.

@longlho longlho merged commit 3f27902 into master Jul 7, 2019
@longlho longlho deleted the null branch July 9, 2019 02:46
@mvestergaard
Copy link
Contributor

This change seems to be causing warnings about missing key when using rich content in message values. Specifically this change appears to be the cause https://github.com/formatjs/react-intl/pull/1354/files#diff-02d37c347364c13c106d74a9319ab545R157
There was a comment there that explains that this type of issue would happen when not using React.createElement. It should probably be changed back to that approach?

@longlho
Copy link
Member Author

longlho commented Jul 9, 2019

@mvestergaard would u mind creating a GH issue?

@mvestergaard mvestergaard mentioned this pull request Jul 9, 2019
Closed
@ipanasenko
Copy link
Contributor

I think you forgot to update types. TypeScript doesn't allow to set textComponent="" on IntlProvider

@marcesengel
Copy link
Collaborator

Hahaha the comment even was left untouched :D

@longlho longlho added this to the v3.0.0 milestone Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redonkulus redonkulus redonkulus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@longlho @mvestergaard @ipanasenko @marcesengel @redonkulus