Change type to allow autocompletion and existence checking #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contributions! Looks like the build is failing bc of |
|
@longlho Sorry about that. I've run |
|
That's really nice, was about to file the same things during the weekend. Looks like what I want to do have been already fixed. ❤️ Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current types don't help the user with using defined messages.
The old DefinitelyTyped types supported this much better.
I'l updated the types in this project based on the DefinitelyTypes ones at https://github.com/DefinitelyTyped/DefinitelyTyped/blob/696809615107a57fc0b2c4d8efacf60622486655/types/react-intl/index.d.ts#L44
With this change, you can autocomplete defined translations as well as receive a type error when you attempt to use a message this is not defined.