Feature request: custom timespan and manual check for multiplayer turn

[Cwpute]

Is your feature request related to a problem? Please describe.
The timespan between game status checks for multiplayer games allows for set timers ranging from 3 seconds to 15 minutes, which is nice… but what if i want to check every hour ? every day ?
What if i want to only check manuall ? or on startup ? These options are not available unfortunately.

Describe the solution you'd like
The ability to enter a custom timespan in the game status check options. you would enter a number and choose the units in in a dropdown menu (seconds, minutes, hours… days ? why not).
Also allow for only checking manually. This would need the implementation of a button, possibly on the multiplayer games' panel.

Describe alternatives you've considered
Include longer timespans in the dropdown list ? half an hour, 1 hour, 3 hours, 6 hours, 12 hours and 24 hours would probably be enough.

[SomeTroglodyte]

Well, they're defined here: https://github.com/yairm210/Unciv/blob/master/core/src/com/unciv/ui/popups/options/MultiplayerTab.kt#L62

Since mp is not my area, and I'd prefer an option that turns off all internet traffic for mp checks, and that would need more changes... And I still assume there is a major update to all that mp stuff in the works (#9497) which may replace/update this.

[SomeTroglodyte]

... and consider the comment // Games that haven't been updated in a week are considered stale in MultiplayerTurnCheckWorker - so yes >24h should not be offered.

So go ahead, PR a change to that createRefreshOptions(ChronoUnit.MINUTES, 1, 2, 5, 15), to createRefreshOptions(ChronoUnit.MINUTES, 1, 2, 5, 15, 30, 60, 180, 360, 720, 1440),, and you'll level up to Contributor. (But honestly, that can't go wrong, but it may actually display as minutes throughout, no idea - actually yes that should be done by FormattingExtensions.kt: Duration.format() - and it looks intelligent enough)

[Cwpute]

... and consider the comment // Games that haven't been updated in a week are considered stale in MultiplayerTurnCheckWorker - so yes >24h should not be offered.

Fallacious argument: this was somewhat arbitrarily stated that, for most games, a week without plays makes a stale game, and can as arbitrarily be changed, isn't it ?
What if the people i play with usually skeep one or two weeks because they're on vacation, or busy at work ? as a player, i don't mind, if they give me a warning before (but that's out of this issue's scope).
What's even a stale game like ? what does that do ?

So go ahead, PR a change to that

Ooh, never made a PR before but actually… i may have some time this week 👀 idk. Don't take my word for it.

[yairm210]

All that means is that we don't check those games every X amount of time
Since most players checks every 10 seconds, it avoids unnecessary traffic
But if you're only checking once a day, we can definitely show checking more stuff

[Cwpute]

Ooh, never made a PR before but actually… i may have some time this week 👀 idk. Don't take my word for it.

Didn't have the time to do it, and won't until a good while. Anyone willing to do it is free to do so.

[SomeTroglodyte]

they're on vacation

Oooh I'm envious... But seriously: That means if you offer longer check times, you'll also need to modify that code that would otherwise mark such lazy games as stale (with consequences I don't know). Doesn't mean you can't or shouldn't.

[github-actions]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.

[github-actions]

This issue was closed because it has been stalled for 5 days with no activity.