Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this gem work with Rails 6? #142

Open
ghost opened this issue May 21, 2021 · 7 comments
Open

Does this gem work with Rails 6? #142

ghost opened this issue May 21, 2021 · 7 comments

Comments

@ghost
Copy link

ghost commented May 21, 2021

I think I'll try it but just a kind nudge to update the docs if it does...

@tovodeverett
Copy link

I use it with Rails 6 (haven't tested 6.1 yet, but I will be dealing with that sometime in the next month or two).
See #20 (comment) for some monkey patches I use in Rails 6 in order to better handle databases that have referential integrity.

Unfortunately, the last commit to master was almost three years ago. I don't have the skill set to manage a gem properly nor the time in my personal life to develop and maintain that skill set, so in order to get updates into master someone with that skill set would need to step forward to take over ownership and then figure out how to get ownership transferred.

@t12nslookup
Copy link

I can't see why anyone needs to take ownership, as this looks like it should just carry on working.

3 years ago the requirement limiting it to maximum rails 5.1 was removed, and (although it doesn't work on my current database because "The table is encrypted") ... (briefly) looking at the source code: this should be fit to work exactly as intended in newer versions.

@tovodeverett
Copy link

If you are using referential integrity in your database, the gem can run into issues, thus my set of monkey patches referenced above.

@t12nslookup
Copy link

Okay, I can see that now :-/

taking ownership of a gem is easy if you're in contact with an existing maintainer, very difficult if they don't exist any more (I have experience!) ... with your changes, we'd also need to change the gemspec so that it excludes rails < 6, maybe even pushing 2 versions, 1 with the existing code and a new maximum rails, and 1 with your changes and a new minimum

@tovodeverett
Copy link

In addition, it would be wise to expand the test suite to validate my code changes, to test against additional database providers besides Postgres, and so forth. I've never managed a gem, so I don't know all of the ins and outs of getting CI running, configuring testing for all the various combinations, building gem deployment packages for the repositories, etc. I just have this vague understanding that there is a whole knowledge base required to do that properly, and I know I don't have it! At the end of the day, monkey patching is a low-friction way for me to continue to use older gems that are no longer actively maintained, but that need some tweaks to work properly for my use case. I keep a monkey_patches.rb file in my config/initializers directory and make sure I document what I do in there and why. Then I post the monkey patches where others can benefit - it's not ideal, but it's better than nothing.

@dnrce
Copy link
Member

dnrce commented Dec 23, 2021

I just opened #143 -- if anyone here is interested in leading the project or has thoughts about it, please chime in!

@internet-exploder
Copy link

just worked on rails 7 better than postgres dump to sqlite edits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants