You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! Yes, this is definitely a bug, thanks for noticing! To keep the code compatible with the reported results, I will fix it in a way that will "preserve the bug", but will be less confusing.
Hi! The following line in method
make_parameter_goups
looks very much like a mistypehttps://github.com/yandex-research/tabular-dl-tabr/blob/75105013189c76bc4f247633c2fb856bc948e579/lib/deep.py#L364C46-L364C60
because of it we never add anything to
params_without_wd
which defeats the purpose ofzero_weight_decay_condition
The text was updated successfully, but these errors were encountered: