Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in make_parameter_groups #19

Open
NikolayXHD opened this issue Feb 25, 2024 · 1 comment
Open

Bug in make_parameter_groups #19

NikolayXHD opened this issue Feb 25, 2024 · 1 comment

Comments

@NikolayXHD
Copy link

Hi! The following line in method make_parameter_goups looks very much like a mistype

https://github.com/yandex-research/tabular-dl-tabr/blob/75105013189c76bc4f247633c2fb856bc948e579/lib/deep.py#L364C46-L364C60

params_with_wd if needs_wd else params_with_wd

because of it we never add anything to params_without_wd which defeats the purpose of zero_weight_decay_condition

@Yura52
Copy link
Contributor

Yura52 commented Feb 26, 2024

Hi! Yes, this is definitely a bug, thanks for noticing! To keep the code compatible with the reported results, I will fix it in a way that will "preserve the bug", but will be less confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants