Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not write preprocessed configs to /etc/ #2443

Merged
merged 207 commits into from
Nov 27, 2018
Merged

Conversation

proller
Copy link
Contributor

@proller proller commented May 29, 2018

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

@filimonov
Copy link
Contributor

👍

Это была одна из претензий наших ОПсов к кликхаусу :)

@proller proller merged commit f1791e9 into ClickHouse:master Nov 27, 2018
proller added a commit to proller/ClickHouse that referenced this pull request Nov 30, 2018
@filimonov
Copy link
Contributor

filimonov commented Jan 25, 2019

Small issue with that: when starting clickhouse-server like that

clickhouse-server --config /etc/clickhouse-server/config.xml -- --path=/tmp/bbb --http_port=30000 --tcp_port=30001 --interserver_http_port=30002 --logger.log=/dev/null --logger.errorlog=/dev/null

it still tries to access /var/lib/clickhouse//preprocessed_configs/config.xml (and ALSO writing /tmp/bbb/preprocessed_config)

Did you consider writing to "preprocessed" the values which were overwritten by command line parameters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants