ClickHouse 3551 Remove external dictionaries, when config updated #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesapin
reviewed
Aug 3, 2018
| @@ -166,8 +169,8 @@ class ExternalLoader | |||
| /// Check objects definitions in config files and reload or/and add new ones if the definition is changed | |||
| /// If loadable_name is not empty, load only loadable object with name loadable_name | |||
| void reloadFromConfigFiles(bool throw_on_error, bool force_reload = false, const std::string & loadable_name = ""); | |||
| void reloadFromConfigFile(const std::string & config_path, bool throw_on_error, bool force_reload, | |||
| const std::string & loadable_name); | |||
| void reloadFromConfigFile(const std::string & config_path, const bool throw_on_error, | |||
There was a problem hiding this comment.
А зачем параметры, передающиеся по значению, делать константными?
There was a problem hiding this comment.
Видимо это случайно так вышло.
There was a problem hiding this comment.
Один из наших коллег так писал из приципа. На мой взгляд - не плохо и не хорошо.
|
You should add integration test (or at least estimate how hard it would be to add integration test for this feature). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en