CLICKHOUSE-3878: ODBC-Bridge tool implementation #2828
Conversation
…ange format of columns in request, more convinient exception messages
| size_t parseMaxBlockSize(const std::string & max_block_size_str, Poco::Logger * log) | ||
| { | ||
| size_t max_block_size = DEFAULT_BLOCK_SIZE; | ||
| if (!max_block_size_str.empty()) |
There was a problem hiding this comment.
We should throw an exception if the user specified &max_block_size=
| { | ||
| try | ||
| { | ||
| max_block_size = std::stoul(max_block_size_str); |
There was a problem hiding this comment.
It doesn't work as expected:
milovidov@milovidov-Pro-P30:~/work/ClickHouse$ g++ -std=c++17 -xc++ -include string - <<< 'int main() { return std::stoul("123abc"); }'
milovidov@milovidov-Pro-P30:~/work/ClickHouse$ ./a.out
milovidov@milovidov-Pro-P30:~/work/ClickHouse$ echo $?
123
Better to use parse function from ReadHelpers.h
There was a problem hiding this comment.
Need to check for all possibly wrong usages of std::sto... functions in our codebase.
| } | ||
| catch (...) | ||
| { | ||
| tryLogCurrentException(log); |
There was a problem hiding this comment.
No need to catch exception.
| return sample_block; | ||
| } | ||
|
|
||
| size_t parseMaxBlockSize(const std::string & max_block_size_str, Poco::Logger * log) |
There was a problem hiding this comment.
No need for this function at all.
| return std::make_shared<Poco::Data::SessionPool>("ODBC", connection_str); | ||
| })); | ||
| } | ||
| return pool_map->at(connection_str); |
There was a problem hiding this comment.
Why we don't lock mutex here?
|
|
||
| ODBCHandler::PoolPtr ODBCHandler::getPool(const std::string & connection_str) | ||
| { | ||
| if (!pool_map->count(connection_str)) |
| } | ||
| catch (const Exception & ex) | ||
| { | ||
| process_error("ODBCBridge: Invalid 'columns' parameter in request body '" + ex.message() + "'"); |
There was a problem hiding this comment.
Exception stack trace is lost.
|
|
||
| std::string format = params.get("format", "RowBinary"); | ||
| std::string query = params.get("query"); | ||
| LOG_TRACE(log, "ODBCBridge: Query '" << query << "'"); |
There was a problem hiding this comment.
You put query in single quotes, but query is unescaped - that may lead to confusion, because query often contains single quotes inside.
Better to print query after colon.
| { | ||
| options.addOption(Poco::Util::Option("http-port", "", "port to listen").argument("http-port", true).binding("http-port")); | ||
| options.addOption( | ||
| Poco::Util::Option("http-host", "", "hostname to listen, default localhost").argument("http-host").binding("http-host")); |
There was a problem hiding this comment.
All parameters in configuration file that exists in clickhouse-server, should be named exactly as in clickhouse-server.
There was a problem hiding this comment.
Ok, but may I save --log-level in place of --logger.level? I think my variant is much more readable and common. Also, this tool (in contrast to clickhouse-server) provides --help option.
There was a problem hiding this comment.
Ok. Could you please also add --log-level to clickhouse-server?
(--help is also missing, we have a few complaints about it)
dbms/src/Storages/StorageODBC.cpp
Outdated
| while (!checkODBCBridgeIsRunning() && counter <= 5) | ||
| { | ||
| sleep(1); | ||
| counter++; |
dbms/src/Storages/StorageODBC.cpp
Outdated
| while (!checkODBCBridgeIsRunning() && counter <= 5) | ||
| { | ||
| sleep(1); | ||
| counter++; |
dbms/src/Storages/StorageODBC.cpp
Outdated
| { | ||
| const auto & config = context_global.getConfigRef(); | ||
| const auto & settings = context_global.getSettingsRef(); | ||
| Poco::Path path{config.getString("application.dir", "")}; |
There was a problem hiding this comment.
What is application.dir?
There was a problem hiding this comment.
https://github.com/ClickHouse-Extras/poco/blob/3df947389e6d9654919002797bdd86ed190b3963/Util/include/Poco/Util/Application.h#L76 -- It stores information about executable path. I don't know other reliable and cross-platform (linux and macOS) ways to get it from source code.
…ore explicit logging, fix mutex bug, add SCOPE_EXIT in bridge
|
I don't understand why travis fails. Seems that the main reason is internal timeouts. |
…redundant headers, fix compilation issues
|
Single failed test in Autotests and Travis is |
WIP
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en