[CLICKHOUSE-3476] add invalidate_query for ClickHouse in Dictionary #3126
Conversation
| return readInvalidateQuery(dynamic_cast<IProfilingBlockInputStream&>((*input_block))); | ||
| } | ||
|
|
||
| auto invalidate_stream = RemoteBlockInputStream(pool, request, invalidate_sample_block, context); |
There was a problem hiding this comment.
Why not RemoteBlockInputStream invalidate_stream(pool, request, invalidate_sample_block, context);?
| @@ -143,4 +159,19 @@ BlockInputStreamPtr ClickHouseDictionarySource::createStreamForSelectiveLoad(con | |||
| return std::make_shared<RemoteBlockInputStream>(pool, query, sample_block, context); | |||
| } | |||
|
|
|||
| std::string ClickHouseDictionarySource::doInvalidateQuery(const std::string & request) const | |||
| { | |||
| Block invalidate_sample_block; | |||
There was a problem hiding this comment.
Unused variable in case of is_local. Better to create if (is_local) ... else ....
| @@ -143,4 +159,19 @@ BlockInputStreamPtr ClickHouseDictionarySource::createStreamForSelectiveLoad(con | |||
| return std::make_shared<RemoteBlockInputStream>(pool, query, sample_block, context); | |||
| } | |||
|
|
|||
| std::string ClickHouseDictionarySource::doInvalidateQuery(const std::string & request) const | |||
| { | |||
| Block invalidate_sample_block; | |||
There was a problem hiding this comment.
This block is sample_block, which is used as header. It must contain single string column. Look at similar dictionaries: https://github.com/yandex/ClickHouse/blob/master/dbms/src/Dictionaries/MySQLDictionarySource.cpp#L219-L221 and https://github.com/yandex/ClickHouse/blob/master/dbms/src/Dictionaries/ODBCDictionarySource.cpp#L187-L189
There was a problem hiding this comment.
No! It does not work with CH.
|
Ok. But test is missing. |
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en