Storages/Kafka: fixed deadlocks, moved to background pool #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two deadlocks in Kafka engine found previously: * When exception is thrown before starting reading, consumer was never returned to the storage. Now it is claimed only when actually starting reading. * Fixed lockup on deinitialization when consumer only unsubscribed, but didn't close, and the endine then timeouted when waiting for consumer destruction. This also moves the stream thread to background worker pool. The reason for that is that it will compete with other tasks for time, so it will form a backpressure on insertion when the system is busy.
vavrusa
force-pushed
the
fix-kafka-lockups
branch
from
c711bcc to
ea32434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two deadlocks in Kafka engine found previously:
was never returned to the storage. Now it is claimed only
when actually starting reading.
but didn't close, and the endine then timeouted when waiting for
consumer destruction.
This also moves the stream thread to background worker pool.
The reason for that is that it will compete with other tasks for
time, so it will form a backpressure on insertion when the system
is busy.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
cc @bocharov @dqminh