Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReplicatedMergeTree: send truncate request to the leader replica #3375

Merged
merged 2 commits into from
Oct 13, 2018
Merged

ReplicatedMergeTree: send truncate request to the leader replica #3375

merged 2 commits into from
Oct 13, 2018

Conversation

kshvakov
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Fixed TRUNCATE TABLE T execution on the non-leader replica.

@alexey-milovidov alexey-milovidov changed the title ReplicatedMergeTree: send drop request to the leader replica ReplicatedMergeTree: send truncate request to the leader replica Oct 13, 2018
@alexey-milovidov alexey-milovidov merged commit 4f81931 into ClickHouse:master Oct 13, 2018
@alexey-milovidov
Copy link
Member

Ok.
PS. Could you try to add integration test?
These tests are located in dbms/tests/integration.
More info: https://clickhouse.yandex/docs/en/development/tests/

@kshvakov
Copy link
Contributor Author

OK, I'll add a test soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kshvakov @alexey-milovidov