Some fixes to quantile*() functions related to DateTime argument type #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abyss7
commented
Nov 14, 2018
| { | ||
| private: | ||
| using ColVecType = std::conditional_t<IsDecimalNumber<Value>, ColumnDecimal<Value>, ColumnVector<Value>>; | ||
|
|
||
| static constexpr bool returns_float = !std::is_same_v<FloatReturnType, void>; | ||
| static constexpr bool returns_float = !(std::is_same_v<FloatReturnType, void>)&&( |
There was a problem hiding this comment.
Don't return float if FloatReturnType is unspecified.
Don't return float if Value is Date or DateTime.
Always return float if Data is QuantileTiming.
4ertus2
reviewed
Nov 14, 2018
|
The test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression mentioned in #3572
Fix return type for
quantileTiming(level)(DateTime)I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en