Use cluster connections pool in DirectoryMonitor #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhang2014
force-pushed
the
feature/use_cluster_pool
branch
from
a892580 to
4798ab1
Compare
| Protocol::Compression::Enable, | ||
| secure); | ||
| ClusterPtr cluster = storage.getCluster(); | ||
| const auto shards_info = cluster->getShardsInfo(); |
| secure); | ||
| ClusterPtr cluster = storage.getCluster(); | ||
| const auto shards_info = cluster->getShardsInfo(); | ||
| const auto shards_addresses = cluster->getShardsAddresses(); |
| /// existing connections pool have a higher priority | ||
| for (size_t shard_index = 0; shard_index < shards_info.size(); ++shard_index) | ||
| { | ||
| Cluster::Addresses replicas_addresses = shards_addresses[shard_index]; |
|
|
||
| for (size_t replica_index = 0; replica_index < replicas_addresses.size(); ++replica_index) | ||
| { | ||
| Cluster::Address replica_address = replicas_addresses[replica_index]; |
| { | ||
| Cluster::Address replica_address = replicas_addresses[replica_index]; | ||
|
|
||
| if (replica_address.host_name == host && replica_address.port == port |
There was a problem hiding this comment.
Why don't make an operator==?
There was a problem hiding this comment.
Because no other place has similar needs
There was a problem hiding this comment.
Now it's reasonable to have operator==. Because otherwise it's very easy to forget to modify this place if we will add more struct members.
zhang2014
force-pushed
the
feature/use_cluster_pool
branch
3 times, most recently
from
8fdfbf8 to
3363046
Compare
zhang2014
force-pushed
the
feature/use_cluster_pool
branch
from
3363046 to
994d1c0
Compare
alexey-milovidov
added a commit
that referenced
this pull request
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When too many distributed tables are in a single server, a large number of connections are created.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en