Refactor constant folding #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hide behind `distributed_optimize_skip_select_on_unused_shards` setting.
- add test_unavailable_shard cluster
| @@ -89,6 +89,7 @@ struct Settings | |||
| M(SettingBool, skip_unavailable_shards, false, "Silently skip unavailable shards.") \ | |||
| \ | |||
| M(SettingBool, distributed_group_by_no_merge, false, "Do not merge aggregation states from different servers for distributed query processing - in case it is for certain that there are different keys on different shards.") \ | |||
| M(SettingBool, distributed_optimize_skip_select_on_unused_shards, false, "Assumes that data is distributed by sharding_key. Optimization to skip unused shards if SELECT query filters by sharding_key.") \ | |||
There was a problem hiding this comment.
I will rename this setting, because all optimization settings begins with optimize_.
| const auto & slot_to_shard = cluster->getSlotToShard(); | ||
|
|
||
| #define CREATE_FOR_TYPE(TYPE) \ | ||
| if (typeid_cast<const DataType##TYPE *>(result.type.get())) \ |
There was a problem hiding this comment.
It's not the same. See #3683
Better to remove copy-paste.
alexey-milovidov
added a commit
that referenced
this pull request
Dec 20, 2018
|
@abyss7 @alexey-milovidov cool! thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en