Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding xxHash64 and xxHash32 functions #3905

Merged
merged 2 commits into from
Dec 22, 2018

Conversation

filimonov
Copy link
Contributor

@filimonov filimonov commented Dec 21, 2018

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • New Feature

Short description (up to few sentences):
xxHash64 and xxHash32 hashing functions added.

Detailed description (optional):
xxHash functions are fast (~as fast as metroHash), widely used in different usecases, and well portable. It's quite popular - even in ClickHouse contrib it exists 4 times:

./contrib/llvm/llvm/include/llvm/Support/xxhash.h
./contrib/librdkafka/src/xxhash.h
./contrib/lz4/lib/xxhash.h
./contrib/zstd/contrib/linux-kernel/include/linux/xxhash.h
./contrib/zstd/lib/common/xxhash.h

Added to simplify integrations.

I didn't add it as a submodule, used implementation from lz4 which is already included. (Motivation: no extra dep, lz4 - is core ClickHouse part, and author(xxHash) in authors(lz4))

@alexey-milovidov alexey-milovidov merged commit 4a50d98 into ClickHouse:master Dec 22, 2018
@alexey-milovidov alexey-milovidov self-requested a review December 22, 2018 16:21
@alexey-milovidov
Copy link
Member

Ok. And what about performance test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants