Fix group by array low cardinality arguments #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does not build ( |
| @@ -101,8 +101,10 @@ void NativeBlockOutputStream::write(const Block & block) | |||
| /// Send data to old clients without low cardinality type. | |||
| if (remove_low_cardinality || (client_revision && client_revision < DBMS_MIN_REVISION_WITH_LOW_CARDINALITY_TYPE)) | |||
| { | |||
| column.column = recursiveRemoveLowCardinality(column.column); | |||
| column.type = recursiveRemoveLowCardinality(column.type); | |||
| if (auto col = recursiveRemoveLowCardinality(column.column.get())) | |||
There was a problem hiding this comment.
Don't understand the change.
There was a problem hiding this comment.
The main idea is that function recursiveRemoveLowCardinality has changed it's interface. Before function was ColumnPtr -> ColumnPtr, and result was a column without LowCardinality. Now function is IColumn * -> ColumnPtr, and it returns new column only if argument had LowCardinality, and nullptr otherwise.
Reasons:
- If column doesn't contain
LowCardinality, do not create new column object (less impact on ordinary columns). - Can use with raw ptr argument (which was used in Aggregator)
alexey-milovidov
changed the title
ColumnPtr is intrusive: you can always obtain ColumnPtr from raw ptr. |
|
Your own test has failed. |
KochetovNicolai
force-pushed
the
fix-group-by-array-low-cardibality-arguments
branch
from
822f85e to
21242ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):
Short description (up to few sentences):
Fixed aggregate functions execution with
Array(LowCardinality)arguments. #4038