Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brotli support for HTTP interfaces #4235

Merged
merged 19 commits into from
Feb 13, 2019
Merged

Conversation

fandyushin
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • New Feature

Short description (up to few sentences):
Brotli support for HTTP interfaces:
Content-Encoding: br

@alexey-milovidov
Copy link
Member

Looks good.
Need to add a test.

@fandyushin
Copy link
Contributor Author

its seems that I'm done

@alexey-milovidov
Copy link
Member

Ok. Now it is implemented for data insertion.

How hard is to implement BrotliWriteBuffer and to use it when enable_http_compression is enabled and client said that it accepts br? And probably to provide http_brotli_compression_level setting.

Do you want to implement it in next pull request?

@fandyushin
Copy link
Contributor Author

I've fixed .gitmodules. It changes too often :)
I think its not complicated to implement write buffer. I can do it.

@alesapin alesapin merged commit 952aed6 into ClickHouse:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants