Add topKWeighted aggregate function #4245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (set.capacity() != AggregateFunctionTopK<T>::reserved) | ||
| set.resize(AggregateFunctionTopK<T>::reserved); | ||
| set.insert(static_cast<const ColumnVector<T> &>(*columns[0]).getData()[row_num], | ||
| static_cast<const ColumnVector<T> &>(*columns[1]).getData()[row_num]); |
There was a problem hiding this comment.
Function arguments can have different types.
try SELECT topKWeighted(10)(number, number % 100) FROM numbers(1000)
alexey-milovidov
requested changes
Feb 3, 2019
| @@ -48,16 +48,21 @@ static IAggregateFunction * createWithExtraTypes(const DataTypePtr & argument_ty | |||
| return new AggregateFunctionTopKGeneric<false>(threshold, argument_type); | |||
| } | |||
|
|
|||
| template<bool weighed> | |||
alexey-milovidov
changed the title
|
It doesn't work for generic types: |
alexey-milovidov
added a commit
that referenced
this pull request
Feb 10, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Feb 10, 2019
alexey-milovidov
added a commit
that referenced
this pull request
Feb 10, 2019
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):
Short description (up to few sentences):
Added
topKWeightedaggregate function that takes additional argument with (unsigned integer) weight.