Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD AIO support. #4305

Merged

Conversation

vitlibar
Copy link
Member

@vitlibar vitlibar commented Feb 7, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

#4302

Category (leave one):

  • Improvement

Short description (up to few sentences):
Implemented AIO support for FreeBSD.

@proller
Copy link
Contributor

proller commented Feb 7, 2019

../dbms/src/IO/AIO.cpp: In function 'int io_getevents(int, long int, long int, kevent*, timespec*)':
../dbms/src/IO/AIO.cpp:123:32: warning: parameter 'min_nr' set but not used [-Wunused-but-set-parameter]
 int io_getevents(int ctx, long min_nr, long max_nr, struct kevent * events, struct timespec * timeout)
                           ~~~~~^~~~~~
../dbms/src/IO/AIO.cpp: In constructor 'AIOContext::AIOContext(unsigned int)':
../dbms/src/IO/AIO.cpp:130:37: warning: parameter 'nr_events' set but not used [-Wunused-but-set-parameter]
 AIOContext::AIOContext(unsigned int nr_events)
                        ~~~~~~~~~~~~~^~~~~~~~~

@proller
Copy link
Contributor

proller commented Feb 7, 2019

../dbms/src/IO/WriteBufferAIO.cpp:202:32: warning: use of old-style cast [-Wold-style-cast]
    bytes_written = aio_return((struct aiocb *)event.udata);
                               ^               ~~~~~~~~~~~
1 warning generated.
[1093/1771] Building CXX object dbms/CMakeFiles/clickhouse_common_io.dir/src/IO/ReadBufferAIO.cpp.o
[1094/1771] Building CXX object dbms/CMakeFiles/clickhouse_common_io.dir/src/IO/AIOContextPool.cpp.o
../dbms/src/IO/AIOContextPool.cpp:98:41: warning: use of old-style cast [-Wold-style-cast]
        it->second.set_value(aio_return((struct aiocb *)event.udata));
                                        ^               ~~~~~~~~~~~
1 warning generated.

@proller
Copy link
Contributor

proller commented Feb 7, 2019

../dbms/src/IO/AIO.cpp:115:6: warning: variable 'r' may be uninitialized when used here [-Wconditional-uninitialized]
        if (r < 0) {
            ^
../dbms/src/IO/AIO.cpp:93:10: note: initialize the variable 'r' to silence this warning
    int r;
         ^
          = 0

../dbms/src/IO/AIOContextPool.cpp:98:41: warning: use of old-style cast [-Wold-style-cast]
        it->second.set_value(aio_return((struct aiocb *)event.udata));
                                        ^               ~~~~~~~~~~~

../dbms/src/IO/WriteBufferAIO.cpp:202:32: warning: use of old-style cast [-Wold-style-cast]
    bytes_written = aio_return((struct aiocb *)event.udata);
                               ^               ~~~~~~~~~~~

@vitlibar vitlibar force-pushed the add-freebsd-aio-support branch from c6c6ccd to 114d984 Compare February 7, 2019 18:49
@vitlibar vitlibar force-pushed the add-freebsd-aio-support branch from 114d984 to 49611e8 Compare February 8, 2019 13:37
@alexey-milovidov
Copy link
Member

alexey-milovidov commented Feb 8, 2019

Missing changelog.
Added.

@alexey-milovidov alexey-milovidov merged commit e7541f0 into ClickHouse:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants