Improve push-down logic for joined statements #4387
Conversation
abyss7
force-pushed
the
CLICKHOUSE-4268
branch
2 times, most recently
from
f3c84ac to
1344ff6
Compare
|
|
||
| -- Optimize predicate expression with view | ||
| -- TODO: simple view is not replaced with subquery inside syntax analyzer | ||
| ANALYZE SELECT * FROM test.test_view WHERE id = 1; |
There was a problem hiding this comment.
Maybe the same as #4387 (comment) ?
There was a problem hiding this comment.
No, it's not the same - at least from the SyntaxAnalyzer point of view.
abyss7
force-pushed
the
CLICKHOUSE-4268
branch
from
1344ff6 to
bc5e75e
Compare
| ANALYZE SELECT id FROM test.test_view WHERE id = 1; | ||
| ANALYZE SELECT s.id FROM test.test_view AS s WHERE s.id = 1; | ||
|
|
||
| -- TODO: this query shouldn't work, because the name `toUInt64(sum(id))` is undefined for user |
There was a problem hiding this comment.
I'm going to fix this. Maybe SELECT * FROM (SELECT toUInt64(b), sum(id) AS b FROM test.test) WHERE `toUInt64(b)` = 3; should work ?
There was a problem hiding this comment.
No, the problem is the opposite: it works now, but it shouldn't, because we somehow allow users to exploit internal aliases. This should be fixed by hiding internal aliases from user. Potentially, we can change internal alias naming scheme any time and such queries will become invalid.
There was a problem hiding this comment.
The alias is actually added for support SELECT * FROM (SELECT 1) WHERE `1` = 1 , it works without predicate optimization. original pull request: #3107
There was a problem hiding this comment.
Oh, yes, it's not related to the push-down - it's a standalone issue. I discussed it with @alexey-milovidov already.
that prints out the query after syntax analysis. Should be helpful for tests.
to support push-down while analyzing.
abyss7
force-pushed
the
CLICKHOUSE-4268
branch
from
ed09087 to
09af551
Compare
| @@ -594,8 +596,28 @@ Names qualifyOccupiedNames(NamesAndTypesList & columns, const NameSet & source_c | |||
| return originals; | |||
| } | |||
|
|
|||
| void replaceJoinedTable(const ASTTablesInSelectQueryElement* join) | |||
abyss7
changed the title
Also implement the debug query "ANALYZE", which prints out the query after syntax analysis. Should be helpful for tests.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en