Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better replica repair #4399

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Better replica repair #4399

merged 2 commits into from
Feb 14, 2019

Conversation

alexey-milovidov
Copy link
Member

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Improvement

Short description (up to few sentences):
Allow to repair abandoned replica even if it already has huge number of nodes in its queue.

Copy link
Member

@alesapin alesapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. Even if we purge our queue and fail clone, we still can do this on the next retry of start up.

@alesapin
Copy link
Member

Maybe we can add integration test? Fill one replica queue with trash, and after that test is_lost logic.

@alexey-milovidov
Copy link
Member Author

Fill one replica queue with trash

It can be done only with manual creating of nodes, because by itself, replica is moving log entries to its queue and processes them almost immediately.

@alexey-milovidov alexey-milovidov merged commit ed3a8a6 into master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants