Set update_time on full executable dictionary update

[temoon]

This fixes issue #4524.

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

• Bug Fix

Short description (up to few sentences):
Set update_time on full executable dictionary update.

[alexey-milovidov]

The code (not yours) is terrible and should be rewritten.

std::string getUpdateFieldAndDate();
There is no comment about this method.
The name of the method is misleading.
It is not qualified as const despite its name and it changes update time by surprise.

char buffer[80];
struct tm * timeinfo;
timeinfo = localtime(&hr_time);
strftime(buffer, 80, "\"%Y-%m-%d %H:%M:%S\"", timeinfo);
std::string str_time(buffer);

Using obsolete C functions for time formatting. DateLUT can be used instead.

[alexey-milovidov]

The logic in code is also flawed. We cannot use client side time to compare it on server side.

[temoon]

Thanks for reply, Alexey.

I use of about 70 million rows sized external dictionary which has frequently updates (~5k entries per second), and full dump tooks few minutes :((
Even is this form of functionality is very helpful for me!

[alexey-milovidov]

Ok. I have rewritten it a little, but I doubt that it is covered by tests, so good luck.