Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExternalDictionaries: don't lock when checking if a dictionary is modified #4599

Merged

Conversation

alexey-milovidov
Copy link
Member

@alexey-milovidov alexey-milovidov commented Mar 5, 2019

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Bug Fix

Short description (up to few sentences):
Avoid deadlock when the invalidate_query for a dictionary with clickhouse source was involving system.dictionaries table or Dictionaries database (rare case). This PR also fixes #4597.

@abyss7
Copy link
Contributor

abyss7 commented Mar 6, 2019

Do we need this in any 19.1 or 19.3 versions, when it gets merged?

@alexey-milovidov
Copy link
Member Author

Yes.

@alexey-milovidov alexey-milovidov merged commit 84763b1 into master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set system.dictionaries.last_exception when invalidate_query fails
2 participants