Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about self.label_emb #20

Open
2hiTee opened this issue Nov 17, 2024 · 1 comment
Open

Questions about self.label_emb #20

2hiTee opened this issue Nov 17, 2024 · 1 comment

Comments

@2hiTee
Copy link

2hiTee commented Nov 17, 2024

Thanks for your wonderful work! I have a question that you said you based on pre-trained SVD to train the first stage Hi3D model. But the original SVD used FPS and bucket_id as the additional condition together with timestep embedding, and the dimension is 768. Here in the configuration file, I see you changed these two condition with elevation and aesthetic condition but starting with the same label embedding. Do you think this works well? Thanks!

@yanghb22-fdu
Copy link
Owner

In our experiments, the FPS and bucket_id conditions were found to be insignificant, so we replaced these conditions. For the new setup, elevation as a 3D condition has a significant impact on the final results. To simplify implementation and minimize changes to the network architecture and code, we opted for an aesthetic condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants