Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsx-closing-bracket-location after-props rule doesn't work when prop value is a function #199

Closed
EvHaus opened this issue Aug 27, 2015 · 1 comment

Comments

@EvHaus
Copy link
Collaborator

EvHaus commented Aug 27, 2015

I have jsx-closing-bracket-location set to after-props. However, it's throwing a warning where it shouldn't. This happens when a prop is defined as a function, like this:

<div
    something={true}
    onClick={event => {
        console.log(event); 
    }} />

This throws a warning, but it shouldn't.

@yannickcr
Copy link
Member

Right, currently the rule only check if the closing bracket is on the same line as the last prop, which does not work if the prop value is on multiple lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants