-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsx-curly-spacing autofix deletes comments #648
Comments
Title should probably be changed to "jsx-curly-spacing doesn't account for comments" since things like |
@yannickcr Your commit unfortunately doesn't seem to fix this issue. The example provided by @lencioni still produces the buggy result of removing the comment (tested using 7.3.0). So I would argue that this issue should be re-opened. |
The commit includes automated tests that should verify it's working. Can you open a PR that includes a failing test case? |
Was that what you had in mind? |
Thanks, that's appreciated! I'll take a look soon. |
Cool, thanks for the update! |
If I have some JSX like:
the autofixer will change it to:
but it should change it to:
The text was updated successfully, but these errors were encountered: