Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsx-no-bind errors on non-react components. #663

Closed
ljharb opened this issue Jul 6, 2016 · 2 comments
Closed

jsx-no-bind errors on non-react components. #663

ljharb opened this issue Jul 6, 2016 · 2 comments
Labels
bug

Comments

@ljharb
Copy link
Member

ljharb commented Jul 6, 2016

I have Backbone views with a "render" method that are being warned when they have .bind used within them. Did something change recently that loosened the criteria for identifying a React component?

If the render method doesn't return JSX, and the component doesn't extend React.Component, and most importantly if the file itself doesn't even import/require React, why are these rules applying to it?
@ljharb ljharb added the bug label Jul 6, 2016
@ljharb ljharb mentioned this issue Jul 6, 2016
Closed
@frenzzy frenzzy mentioned this issue Jul 10, 2016
Closed
petersendidit added a commit to petersendidit/eslint-plugin-react that referenced this issue Jul 12, 2016
@petersendidit
Fix jsx-no-bind reporting errors on render functions that don't return
8c61d14 
JSX (Fixes jsx-eslint#663)
@petersendidit petersendidit mentioned this issue Jul 12, 2016
Merged
petersendidit added a commit to petersendidit/eslint-plugin-react that referenced this issue Jul 12, 2016
@petersendidit
Fix jsx-no-bind reporting errors on render functions that don't return
025305e 
JSX (Fixes jsx-eslint#663)
Enhance isReturningJSX to handle more node types
petersendidit added a commit to petersendidit/eslint-plugin-react that referenced this issue Jul 13, 2016
@petersendidit
Fix jsx-no-bind reporting errors on render functions that don't return
cf0ff04 
JSX (Fixes jsx-eslint#663)
Enhance isReturningJSX to handle more node types
yannickcr pushed a commit that referenced this issue Jul 14, 2016
@petersendidit @yannickcr
Fix jsx-no-bind reporting errors on render functions that don't retur…
ae5a43b 
…n JSX (fixes #663)
@ljharb
Copy link
Member Author

ljharb commented Jul 15, 2016

@yannickcr can you bump the alpha? (or better, the major :-) )

@yannickcr
Copy link
Member

@ljharb I just published v6.6.0-alpha.2 with this fix (among others).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yannickcr @ljharb