-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error location #1666
Fix error location #1666
Conversation
<a>bar</a> | ||
</App> | ||
`, | ||
code: `<App> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this kind of seems like you maybe ran prettier on the output; could you revert all those unrelated changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is related in the sense that I wanted to remove extraneous whitespace from the test cases, so that the loc test assertions were more predictable and were not affected by the indentation of the surrounding code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having code: `\n
seems like it achieves that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not positive I understand, but I updated this to make it clearer. the indentation is still flush with column 1 so that the column counts are fixed, but the code samples now begin with a newline which may help with readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, makes sense :-) rebased, will merge soon.
7736c09
to
05c49d4
Compare
Fixes #1660