Support detecting React.forwardRef/React.memo #2089
Conversation
This updates the component detection to allow for considering components wrapped in either React.forwardRef or React.memo.
jomasti
force-pushed
the
feature/support-react-forwardref-memo
branch
from
efb7ee5 to
341bb4f
Compare
| if (node.type !== 'CallExpression') { | ||
| return false; | ||
| } | ||
| const propertyNames = ['forwardRef', 'memo']; |
There was a problem hiding this comment.
Should these kick in only when the React version setting is 16.3 and 16.6 respectively?
There was a problem hiding this comment.
Should they? Would this break anything for people on earlier versions?
There was a problem hiding this comment.
Probably not, no - but it might be weird to see a warning about a React feature that you can’t use yet.
There was a problem hiding this comment.
This wouldn't show any warnings related to the features. It only improves the detection of components using them. So, if they aren't use the features, nothing happens, right? But I could see the case for not running the check on earlier versions.
There was a problem hiding this comment.
Yeah that’s a fair point too. I’m not really sure whether it’s better to keep it simple and run the checks always, or to only run the checks when the version dictates.
jomasti
force-pushed
the
feature/support-react-forwardref-memo
branch
from
4704762 to
2010245
Compare
Also, the detection actually works now.
jomasti
force-pushed
the
feature/support-react-forwardref-memo
branch
from
2010245 to
3ce2078
Compare
ghost
mentioned this pull request
This updates the component detection to allow for considering components
wrapped in either React.forwardRef or React.memo.
Resolves #1841. Resolves #2059