Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]self-closing-comp: stop reporting single-line spaces #2210

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

golopot
Copy link
Contributor

@golopot golopot commented Mar 22, 2019

Closes #1717

React does not trim JSXText if it is single-line spaces.
In case like <span> </span>, the spaces are left as is.

Closes jsx-eslint#1717

React does not trim JSXText if it is single-line spaces.
In case like `<span>    </span>`, the spaces are left as is.
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

tests/lib/rules/self-closing-comp.js Show resolved Hide resolved
tests/lib/rules/self-closing-comp.js Show resolved Hide resolved
@ljharb ljharb merged commit f6becb1 into jsx-eslint:master Apr 12, 2019
@golopot golopot deleted the issue-1717 branch May 10, 2019 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Spaces get condensed by --fix when they are alone in a <span>
2 participants