Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the use of free model #11

Open
kangmintong opened this issue Oct 14, 2020 · 4 comments
Open

About the use of free model #11

kangmintong opened this issue Oct 14, 2020 · 4 comments

Comments

@kangmintong
Copy link

Hi, yaoyao
I'm quite confused about the use of free model in your code and I can't find explanations in your essay. I'll appreciate it if you can provide me some details about the function of 'free model' in your code.
Thanks.

@yaoyao-liu
Copy link
Owner

Hi @kkmtmkk,

Thanks for your interest in our work. free_model is a model interface for our other project. In this work, it is set as None as follows,
https://github.com/yaoyao-liu/mnemonics-training/blob/42890b9c468ca73334354f29a0d1fd16ed9b9453/1_train/trainer/mnemonics.py#L100
We don't use it during training. So you may directly ignore this variable.

If you have any further questions, feel free to leave additional comments here or send me an email.

Best,
Yaoyao

@kangmintong
Copy link
Author

Thanks for your clear explanations.
Also, I have another question. When I want to reproduce your result in table1 which reaches 64.95 on cifar100, I find the hyperparameters set in source code is inconsistent with that in your essay. I'll appreciate it if you can give some clues on the parameters when reproducing the result 64.95 on cifar100.
Thanks.
Best,
Mintong

@yaoyao-liu
Copy link
Owner

Hi @kkmtmkk,

We fix some bugs in the previous code and update the results in the latest arXiv version. Please refer to these results.

To reproduce the latest results, you need to change the baseline to LUCIR, i.e., replacing https://github.com/yaoyao-liu/mnemonics-training/blob/master/1_train/trainer/incremental.py with https://github.com/yaoyao-liu/class-incremental-learning/blob/main/trainer/incremental_lucir.py. I'll merge the two projects later.

Best,
Yaoyao

@kangmintong
Copy link
Author

Thanks for your explanation.

Best,
Mintong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants