Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DOCUMENT_ROOT placeholder to prevent rewriting fastcgi_param #3

Open
jskvara opened this issue Jan 7, 2016 · 3 comments
Open

Comments

@jskvara
Copy link

jskvara commented Jan 7, 2016

In your run.sh script you're using DOCUMENT_ROOT placeholder to replace the root value. But one of fastcgi parameters has exactly same name. So the run.sh script replaces also this parameter.

@jverdeyen
Copy link
Member

Hi @jskvara, thanks for reporting this!
You can make a PR and rename these DOCUMENT_ROOT into DOCUMENT_ROOT_REPLACE?

@jskvara
Copy link
Author

jskvara commented Jan 8, 2016

Sure, I will prepare a PR.
I think APP_ROOT will be better name than DOCUMENT_ROOT_REPLACE. Or do you have any better name for the placeholder?

@jverdeyen
Copy link
Member

👍 for APP_ROOT, as long as it's only the var inside the config files and not the ENV var.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants