Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate components per simulation instead of if-ology in the component logic #1612

Open
grzanka opened this issue Apr 26, 2024 · 2 comments

Comments

@grzanka
Copy link
Contributor

grzanka commented Apr 26, 2024

Main component for "common" scenario. Two separate components which are children of common component and inject additional fields dedicated to given simulator (Fluka and SHIELD-HIT12A).

@grzanka
Copy link
Contributor Author

grzanka commented Apr 26, 2024

@ostatni5 any other good ideas to have nice architecture of components for all simulators

@ostatni5
Copy link
Member

One of my ideas would be to create more generic components that parse config and display appropriate inputs based on that config. Each simulator would require a config object that would define what type of input display, its label, and what would happen after change.

Another approach would be to compose component from per simulator components.

If I have some free time, I could try to construct a proof-of-concept branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants