HasPosition.get_units() always returns None

[kadykov]

To reproduce:

In the configuration yml file:

[daemon_name]
port = 39001
units = "millimeter"

In the daemon class:

class DaemonName(HasPosition, IsDaemon):
    _kind = "DaemonName"

    def __init__(self, name: str, config: Dict[str, Any], config_filepath: Path):
        super().__init__(name, config, config_filepath)
        self.logger.debug("Getting units from get.units(): %s", self.get_units())
        self.logger.debug("Getting units from the config: %s", self._config["units"])

From the client side:

import yaqc

daemon = yaqc.Client(port=39001)
daemon.get_units()

I see that get_units() is covered by tests, but I cannot check it because on my machine most of the tests fail on from yaqd_core import testing.

[ksunden]

This is an intentional choice because units as config is not general to all hardware, and thus is not included in the gas position trait.

Some hardware reports it's units via firmware, other hardware has no units at all, while we have standardized how clients ask for units, how the daemon knows its units is dependent on the individual case.

I would consider adding a separate trait only about units-as-config but I'm reticent to add config-only traits.

[kadykov]

It makes sense. Thank you for your answer.
Do you know if this is mentioned somewhere in the documentation?