Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ell homing behavior relies on busy going to False before homing is complete #16

Open
ksunden opened this issue Sep 21, 2022 · 1 comment

Comments

@ksunden
Copy link
Member

ksunden commented Sep 21, 2022

async def _home(self):

Uses await self._not_busy_sig.wait() to determine when to set the position.

This is less critical than ensuring that the set_position behavior is correct, as homing is usually only done by human interaction that is not rapidly polling the busy state, but still.

@ksunden
Copy link
Member Author

ksunden commented Sep 21, 2022

There is not an explicit message for "home completed" as there is for APT, so some additional care must be taken here... shouldn't be that hard, but yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant