Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.$dialog.info failing vs others #58

Closed
Berkmann18 opened this issue Jan 13, 2020 · 1 comment
Closed

this.$dialog.info failing vs others #58

Berkmann18 opened this issue Jan 13, 2020 · 1 comment

Comments

@Berkmann18
Copy link

I've got this working fine up to the point when I tried to use (taken from a working warning confirmation thing I have in the code):

const reminder = await this.$dialog.info({
        title: 'Template creation',
        text: `Please remember to use the <code>{{yourVariableNameHere}}</code> syntax
        when adding variables (that will be filled as you create a page with said template)`,
        actions: {
          false: {
            color: 'error',
            text: 'Cancel'
          },
          true: {
            color: 'primary',
            text: 'OK'
          }
        }
      });

The above leads to errors, however replacing info with warning/error makes it work.
The only way it works is by doing the following:

const reminder = await this.$dialog.confirm({
        type: 'info',
        title: 'Template creation',
        text: `Please remember to use the <code>{{yourVariableNameHere}}</code> syntax
        when adding variables (that will be filled as you create a page with said template)`,
        actions: {
          false: {
            color: 'error',
            text: 'Cancel'
          },
          true: {
            color: 'primary',
            text: 'OK'
          }
        }
      });

I've tried the same above two variants with success and it appears that this inconsistent behaviour also applies to that.

The demo subtly suggests that it's not a bug, however, this seems inconsistent (only allowing a part of the types one way and allowing all types in another) and possibly not intended?

@yariksav
Copy link
Owner

Resolved in 2.0.12.in 57bfbbe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants