Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation of Predictive Variance? #5

Open
leimao opened this issue Jun 18, 2019 · 2 comments
Open

Calculation of Predictive Variance? #5

leimao opened this issue Jun 18, 2019 · 2 comments

Comments

@leimao
Copy link

leimao commented Jun 18, 2019

Hello Yarin,

It looks like that the description of the outputs in your predict method of the net class does not match to the actual output.

def predict(self, X_test, y_test):
"""
Function for making predictions with the Bayesian neural network.
@param X_test The matrix of features for the test data
@return m The predictive mean for the test target variables.
@return v The predictive variance for the test target
variables.
@return v_noise The estimated variance for the additive noise.
"""

According to your publication, the predictive variance should be the sample variance of T stochastic forward passes plus the inverse model precision tau. (In your case, because the output y is a scalar, the variance are also scalars.) But it looks like that you did not add the inverse of tau when you are calculating the predictive "rmse". In addition, what is the estimate variance with additive noise?

Thank you very much.

Best,

Lei

@malharjajoo
Copy link

I agree with this (although I'm not sure about the last bit: why you are mentioning that variance is required for calculating predictive RMSE ....)

@leimao
Copy link
Author

leimao commented Dec 16, 2019

I agree with this (although I'm not sure about the last bit: why you are mentioning that variance is required for calculating predictive RMSE ....)

It has been half a year since I opened this. Now I almost totally forgot what I have written. I will come back to this later Orz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants