Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Engines section not respected #4345

Closed
1 task
rbirkgit opened this issue Apr 11, 2022 · 4 comments
Closed
1 task

[Bug]: Engines section not respected #4345

rbirkgit opened this issue Apr 11, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@rbirkgit
Copy link

Self-service

  • I'd be willing to implement a fix

Describe the bug

We have an engine section in our packages. It stopped working when updating to Yarn 3.x (from 1.x)

To reproduce

We have this in our package.json

  "engines": {
    "node": ">=14.0",
    "yarn": ">=1.19"
  },

Environment

Windows 11
Node 16.14.2

Additional context

No response

@rbirkgit rbirkgit added the bug Something isn't working label Apr 11, 2022
@rbirkgit rbirkgit changed the title [Bug?]: ENgines section not respected [Bug]: Engines section not respected Apr 11, 2022
@RDIL
Copy link
Member

RDIL commented Apr 11, 2022

This isn't a bug, it's an intentional change. See https://github.com/devoto13/yarn-plugin-engines to re-add the functionality.

@rbirkgit
Copy link
Author

Thanks for the link. May I ask why this is intentional? It seems like an important piece of functionality.

@RDIL
Copy link
Member

RDIL commented Apr 11, 2022

Update: after looking back in the issue history, I remembered #1177 is a thing, which shows that the feature wasn't ported over, instead of being intentionally removed. My personal guess is that the modularity of modern Yarn makes it better as a plugin feature, so the maintainers instead opted to not intentionally port it.

@merceyz
Copy link
Member

merceyz commented Apr 12, 2022

Duplicate of #1177

@merceyz merceyz marked this as a duplicate of #1177 Apr 12, 2022
@merceyz merceyz closed this as completed Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants