-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] PnPify in Visual Studio Code does not support "Go to Definition" #806
Comments
Yes, this is a known issue - there is an open ticket on the VSCode tracker to fix it, we can't do it on our side (I've experimented with it already, we even have a zip extension in this very repository, but without the right hooks it's fairly useless). My best advice is to upvote the VSCode issue to help their team prioritize it 🙂 |
This is also an issue with I'm not sure why some things are resolving to
from here |
@skeate explanation about virtual packages is here: https://yarnpkg.com/advanced/lexicon#virtual-package |
Thanks for that link, though it's a little hard to understand without an example given. But I don't want to derail this issue with a tangent. Do you agree that it's an issue, or should editors be able to access Also, aside for anyone else finding this thread who wants a fix now: |
My mistake, I missed the "caveat" section in the docs on Editor SDKs. Should this issue be closed? |
It's an issue in that I don't expect editors to support the Closing this issue as there's nothing actionable on our side at the moment (for people reaching this, please upvote microsoft/vscode#75559 to show your interest to the VSCode team). |
Describe the bug
When using the PnPify workflow in Visual Studio Code, attempting to "Go to Definition" of a dependency results in VS Code attempting, and failing, to open a source file from inside a zipped package in the cache:
To Reproduce
(This isn't exactly minimal since I don't think Create React App is part of the issue, but it's at least very simple to reproduce, and I don't have time to figure out how to create a project without a template right now. Would appreciate anyone with more context helping break it down a little more)
App.tsx
, try to "Go to Definition" on the React package.Screenshots
Environment if relevant (please complete the following information):
Additional context
Looks like the root of the issue is that it's trying to go inside a zip file.
The text was updated successfully, but these errors were encountered: