Fix User Namespace issues with untaring (#2898)

* removed entry.props.uid=0 for root after we switched from node-tar to tar-fs

* removed root condition from tar extraction

* Set UID and GID to zero when user is root

* Add test to Circles CI and just set chown to false

* Change test script

* Fix sudo test

Author: lawliet89

__tests__/commands/install/integration.js

@@ -29,7 +29,7 @@ async function mockConstants(base: Config, mocks: Object, cb: (config: Config) =
   // the Yarn environment.
 
   const opts = {};
-  
+
   opts.binLinks = base.binLinks;
   opts.cwd = base.cwd;
   opts.globalFolder = base.globalFolder;

__tests__/commands/pack.js

@@ -87,6 +87,7 @@ export async function getFilesFromArchive(source, destination): Promise<Array<st
         strip: 1,
         dmode: 0o555, // all dirs should be readable
         fmode: 0o444, // all files should be readable
+        chown: false, // don't chown. just leave as it is
       }))
       .on('finish', resolve)
       .on('error', reject);

circle.yml

@@ -34,6 +34,9 @@ test:
     - yarn build-dist
     - node ./scripts/build-webpack.js
     - ./scripts/build-deb.sh
+    # Test that installing as root works and that it also works
+    # behind a user namespace which Circle CI tests are run under
+    - sudo env "PATH=$PATH" bin/yarn install --force
 
 deployment:
   release:

src/fetchers/git-fetcher.js

@@ -37,6 +37,7 @@ export default class GitFetcher extends BaseFetcher {
       const untarStream = tarFs.extract(this.dest, {
         dmode: 0o555, // all dirs should be readable
         fmode: 0o444, // all files should be readable
+        chown: false, // don't chown. just leave as it is
       });
 
       const hashStream = new crypto.HashStream();

src/fetchers/tarball-fetcher.js

@@ -8,7 +8,6 @@ import * as constants from '../constants.js';
 import * as crypto from '../util/crypto.js';
 import BaseFetcher from './base-fetcher.js';
 import * as fsUtil from '../util/fs.js';
-import ROOT_USER from '../util/root-user.js';
 
 const invariant = require('invariant');
 const path = require('path');
@@ -82,17 +81,12 @@ export default class TarballFetcher extends BaseFetcher {
       strip: 1,
       dmode: 0o555, // all dirs should be readable
       fmode: 0o444, // all files should be readable
+      chown: false, // don't chown. just leave as it is
     });
 
     extractorStream
       .pipe(untarStream)
       .on('error', reject)
-      .on('entry', (entry: Object) => {
-        if (ROOT_USER) {
-          entry.props.uid = entry.uid = 0;
-          entry.props.gid = entry.gid = 0;
-        }
-      })
       .on('finish', () => {
         const expectHash = this.hash;
         const actualHash = validateStream.getHash();