Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn unable to install from .zip files #1020

Closed
miscbits opened this issue Oct 13, 2016 · 6 comments
Closed

Yarn unable to install from .zip files #1020

miscbits opened this issue Oct 13, 2016 · 6 comments

Comments

@miscbits
Copy link

Do you want to request a feature or report a bug?
feature
What is the current behavior?
if the file being loaded is a zip, the error invalid tar file is returned
If the current behavior is a bug, please provide the steps to reproduce.
save this into bower.json

{
  "name": "app",
  "version": "0.0.1",
  "dependencies": {
    "bootstrap": "http://getbootstrap.com/2.3.2/assets/bootstrap.zip"
  },
}

and run yarn
What is the expected behavior?
The files in the zip should be extracted and added to node_modules
Please mention your node.js, yarn and operating system version.
node v 5.7.0, yarn v0.15.1, Latest MacOS

@csvan
Copy link

csvan commented Oct 23, 2016

Confirming this when using local zips as well, e.g. (from package.json):

...
    "my-local-zip: "file:./bundled/my-local-zip.zip"
...

Running yarn install yields:

error Couldn't find a package.json (or bower.json) file in C:\Users\MyUser\MyProject
\bundled\my-local-zip.zip

However, there is indeed a valid package.json in the zip file, and installation works fine if you unzip manually, remove the .zip for the module in package.json, and then run yarn install again.

Environment details:
OS: Windows 7 Enterprise
Node: 6.9.1
Yarn: 0.16.1

@sebmck
Copy link
Contributor

sebmck commented Oct 26, 2016

We've removed support for Bower, see #1441.

@sebmck sebmck closed this as completed Oct 26, 2016
@miscbits
Copy link
Author

This doesnt address the error here though. If we reference to a zip file in package.json this error would still be thrown

@sebmck
Copy link
Contributor

sebmck commented Oct 26, 2016

npm doesn't support zip files either.

@miscbits
Copy link
Author

miscbits commented Oct 26, 2016

fair enough but that doesn't mean that yarn can't or shouldn't

@csvan
Copy link

csvan commented Oct 26, 2016

Opened a separate feature request since this is no longer relevant for Bower support.

#1483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants