Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album titles that end in ... #27

Closed
MrThickDick opened this issue Oct 2, 2020 · 4 comments
Closed

Album titles that end in ... #27

MrThickDick opened this issue Oct 2, 2020 · 4 comments

Comments

@MrThickDick
Copy link

For some reason the app won't download albums that end in ... such as these examples. I had this issue with a previous version but thought it was that specific album, after this album giving the same error I decided to post this. It doesn't have a problem with albums that start with ... though and it creates the folder for the album fine, so I'm not sure what the problem is. Another weird thing is it doesn't seem to have the same problem with albums that end in one period, only three.

It's actually hard to find albums that end with ... but here are three just to show that it's not just a bad album or something.
https://tidal.com/browse/album/128529449
https://tidal.com/browse/album/234017
https://tidal.com/browse/album/115155695

I also tried this album since it had multiple things Windows doesn't like and ends in \\ and it downloaded without any problem replacing the \\ with ----. So it must be something about ... that causes this. Maybe they need to be changed to --- instead of just apparently being omitted when the folder is renamed during downloading or something.
https://tidal.com/browse/album/36594337

@Wim1975
Copy link

Wim1975 commented Oct 4, 2020

For some reason the app won't download albums that end in ... such as these examples. I had this issue with a previous version but thought it was that specific album, after this album giving the same error I decided to post this. It doesn't have a problem with albums that start with ... though and it creates the folder for the album fine, so I'm not sure what the problem is. Another weird thing is it doesn't seem to have the same problem with albums that end in one period, only three.

It's actually hard to find albums that end with ... but here are three just to show that it's not just a bad album or something.
https://tidal.com/browse/album/128529449
https://tidal.com/browse/album/234017
https://tidal.com/browse/album/115155695

I also tried this album since it had multiple things Windows doesn't like and ends in \ and it downloaded without any problem replacing the \ with ----. So it must be something about ... that causes this. Maybe they need to be changed to --- instead of just apparently being omitted when the folder is renamed during downloading or something.
https://tidal.com/browse/album/36594337

Hi MrThickDick... I noticed the same. Normally dots should not be a problem in foldernames...

Note to the developer : (i'm one myself)
A single dot (without anything else between backslashes) like in ".\abc" means the folder "abc" in the current folder.
Two dots like in "..\abc" means one folder up (and "....\abc" two folders up etc...). This is the old Ms-DOS way of pointing to certain folders...

So I guess some parsing is done replacing too many dots with current folder names ?__

MrThickDick While this 'bug' is still there you CAN rip such albums by making a new playlist and drag the album to that playlist (this adds all the songs of that album) and then you right click on the playlist and select "share>copy playlist link" and you paste it in the gui app and press "download" and it should rip. (Afterwards you can find it under playlists i.s.o. albums.)

Grtz

@MrThickDick
Copy link
Author

Thanks for the help, that's what I did to download those albums but I didn't have this problem with the old versions of this program, I think it may be something that started in the Pro version so it's probably a bug and not something in windows but I don't know for sure.

@Wim1975
Copy link

Wim1975 commented Oct 4, 2020

Thanks for the help, that's what I did to download those albums but I didn't have this problem with the old versions of this program, I think it may be something that started in the Pro version so it's probably a bug and not something in windows but I don't know for sure.

I know what the problem is :
the program tries to create folders ending with one or more dots, and windows simply doesn't allow you to create such folders and it removes all trailing dots prior to creating it.

you can see this when you use run CMD and then you type "md d:\test...".
This does NOT create "d:\test..." but "d:\test"

Probably the program then tries to save to a file "d:\test...\song.flac" which doesn't work of course.

So the developer should remove TRAILING dots in folder names (or replace them with another character)

@yaronzz
Copy link
Owner

yaronzz commented Oct 12, 2020

fixed

@yaronzz yaronzz closed this as completed Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants