Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about selected peer to response #177

Open
i opened this issue Mar 11, 2017 · 2 comments
Open

Add information about selected peer to response #177

i opened this issue Mar 11, 2017 · 2 comments

Comments

@i
Copy link

i commented Mar 11, 2017

It'd be useful to add an option view response headers. In addition, a header that specifies the host that handled the request would be useful information for debugging.

@prashantv
Copy link
Contributor

I think yab will print all response headers by default:
https://github.com/yarpc/yab/blob/dev/main.go#L384

To get the host that handled the request, we'll need to extend our RPC libraries to propagate this information back via headers. I've been pushing for this feature for a while, but it requires every service in the stack to back-propagate this information for it to work.

@prashantv
Copy link
Contributor

However, yab can add information about which peer it specifically selected, which may not be useful when it's a proxy, but is useful in peer-to-peer cases.

@prashantv prashantv reopened this Mar 13, 2017
@prashantv prashantv changed the title Add option to view response headers Add information about selected peer to response Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants