Issue 65 #144
Merged
Issue 65 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dacoaster
requested changes
Mar 16, 2024
src/components/settings/TagsTab.vue
Outdated
Comment on lines
11
to
22
| <input | ||
| type="text" | ||
| placeholder="Add tag" | ||
| @input=" | ||
| (evt) => | ||
| $store.commit('config/editTagText', { | ||
| id: tag.id, | ||
| text: evt.target.value, | ||
| }) | ||
| " | ||
| :value="tag.text" | ||
| /> |
There was a problem hiding this comment.
Please make this a vue-tags-input that they can enter tags directly into. (Without autocomplete.)
src/modules/PersistenceUtility.js
Outdated
| @@ -34,6 +34,7 @@ const defaultConfig = { | |||
| ai: { | |||
| enabled: false, | |||
| }, | |||
| tags: [], | |||
There was a problem hiding this comment.
Please change the name to defaultTags.
src/store/modules/config.js
Outdated
| @@ -16,6 +16,7 @@ export const config = { | |||
| debugMode: false, | |||
| summary: false, | |||
| templates: [], | |||
| tags: [{ id: "1", text: "Canada" }], | |||
There was a problem hiding this comment.
Please change to defaultTags.
src/store/modules/config.js
Outdated
| @@ -114,6 +131,7 @@ export const config = { | |||
| fullConfig: (state) => { | |||
| return state; | |||
| }, | |||
| tags: (state) => state.tags, | |||
There was a problem hiding this comment.
Please change to defaultTags.
dacoaster
requested changes
Mar 18, 2024
There was a problem hiding this comment.
@devknight216 this needs one small update and then its ready to merge
src/components/ControlPanel.vue
Outdated
| @@ -733,6 +734,7 @@ | |||
| <AddEvidenceDialog | |||
| v-if="evidenceData" | |||
| v-model="addEvidenceDialog" | |||
| :evidenceData="evidenceData" | |||
There was a problem hiding this comment.
@devknight216 - This looks like a duplicate of the line below and doesn't exist in the props of AddEvidenceDialog so please remove it
There was a problem hiding this comment.
@dacoaster, just removed that. :) Please merge it on your side.
dacoaster
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
Issue Number: 65
What is the new behavior?
Does this introduce a breaking change?