Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 154: dont store text files for notes on disk #155

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

devknight216
Copy link
Contributor

@devknight216 devknight216 commented Mar 26, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Other (please describe):

What is the current behavior?

Issue Number: 154

What is the new behavior?

  • Note text is not saved as txt file.

Does this introduce a breaking change?

  • No

Does this introduce UI changes? If so, have they been tested on both dark and light modes?

  • Yes

Other information

@devknight216 devknight216 requested a review from dacoaster as a code owner March 26, 2024 10:41
@dacoaster
Copy link
Collaborator

dacoaster commented Mar 27, 2024

@devknight216 - Can you rebase this from ok/integration?

Also, on the timeline there is an empty set of parenthesis by the timestamp when the file name doesn't exist... can you please hide those?
image

@dacoaster dacoaster changed the base branch from ok/integration to da/add-profile March 27, 2024 20:20
@dacoaster dacoaster changed the base branch from da/add-profile to ok/integration March 27, 2024 20:20
@dacoaster dacoaster merged commit 16b23dc into testfiesta:ok/integration Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants