add feature : quicker download of report PDF #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacoaster
reviewed
Mar 27, 2024
src/modules/FileSystemUtility.js
Outdated
| ? item.filePath | ||
| : item.filePath.substring(0, item.filePath.length - 1); | ||
| zip.addLocalFile(sanitizedPath, FILE_TYPES[item.fileType]); | ||
| params.type === "pdf" |
There was a problem hiding this comment.
@dockabernathy01 please put this in an if statement instead. It is hard to read the multi-line ternary operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: quicker download of report PDF #129
Please check the type of change your PR introduces:
What is the current behavior?
Users can only report the session to a zip file.
Issue Number: 129
What is the new behavior?
Now users can report the session to a zip and pdf types.
I have added quicker download of report PDF.