Fix openAI and mindmap issue #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacoaster
reviewed
Apr 8, 2024
Comment on lines
107
to
109
| // ...mapGetters({ | ||
| // config: "config/fullConfig", | ||
| // }), |
There was a problem hiding this comment.
@dockabernathy01 you reverted this to the "old style" of passing configs. Please see how all of the other settings tabs handle this and store the data in state rather than via props. These props like configItem are exactly the sort of thing that should be getting removed in this issue: #147
So please revert these changes around props and getters.
|
@dacoaster , I have updated the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix openAI and mindmap issues