Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement new mindmap #175

Merged
merged 12 commits into from
May 10, 2024

Conversation

SmartWolf1220
Copy link
Contributor

Implemented New Mindmap.

  • Feature

What is the new behavior?

  • Add new Node component.
  • Use dom-to-image to save the mindmap.

@SmartWolf1220
Copy link
Contributor Author

Hello @dacoaster.
I have implemented new mindmap.
Please check and let me know.

@dacoaster
Copy link
Collaborator

@dockabernathy01 here are some issues to be fixed:

  • When new nodes are created that have images in them, they are truncated due to the default node size but as soon as you move them and it redraws them, it fixes the issue
    image-daed0
  • When new nodes are created it often places them on top of other nodes so they need to be spaced out more by default
    image-f6236
  • A single click should only select the node, but it is opening the edit window
  • We should disable the simple edit window that only has the title and status and just use the built in yattie edit windows
  • When a new session is started and the mindmap is empty, we should display some sort of "Get started testing to build a testing tree" message instead of the empty workspace
  • The default window size of the app should be larger so we don't have to scroll so much

@dacoaster
Copy link
Collaborator

@dockabernathy01 is this ready for testing again?

@SmartWolf1220
Copy link
Contributor Author

@dacoaster , Yes. it's ready.

@dacoaster
Copy link
Collaborator

dacoaster commented May 7, 2024

@dockabernathy01 some more issues:

  • notes mindmap nodes often get created on top of other nodes instead of being spread out
  • when a new node is created, it should be automatically selected with the blue background
  • the placeholder text for the empty workspace should be moved up
  • double-click isn't working to edit nodes. it takes 3 clicks
  • the upload button at the top of each map node doesn't do anything so it should probably be removed
  • when you click the link button, it should get a background of a darker color to make it obvious that it is selected and all other link buttons should get a colored background too so it is obvious you can click them to link the nodes
  • notes on the mindmap workspace view are not showing up on the timeline workspace view

@SmartWolf1220
Copy link
Contributor Author

@dacoaster , I have fixed the issues you mentioned.
Please check and let me know.

@dacoaster
Copy link
Collaborator

  • When you close the app and open it on the mindmap workspace it draws all of the bubbles small and truncates the evidence pictures similar to what it was doing before

please just fix this in the next PR

@dacoaster
Copy link
Collaborator

@dockabernathy01 please see above

@dacoaster dacoaster merged commit 3464c1d into testfiesta:ok/integration May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants