Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some values are not sanitized and leads to arbitrary code injection #34

Open
mbo-s opened this issue Apr 26, 2019 · 1 comment
Open
Labels

Comments

@mbo-s
Copy link

mbo-s commented Apr 26, 2019

Similar to cross-solution/YAWIK#543

The values from the JSON will be imported without being sanitized. Affected fields are at least company and location. There can be other fields which produce the same errors, e.g. classification fields

Sample file

{
   "jobs": [
       "id": 1,
       "title": "<h1>Title</h1><script>alert('Title-XSS');</script>",
       "location": "<h1>Location</h1><script>alert('Location-XSS');</script>",
       "link": "http://www.example.com/job/1"
       }
   ]
}
@TiSiE TiSiE added the bug label May 6, 2019
@TiSiE
Copy link
Member

TiSiE commented Jul 10, 2020

For nearly every value in the JobDataInputFilter we can add a StripTags-Filter...

Only the filtering of the templateValues (JobDataInputFilter#L193-L230 cannot simply strip all tags, because at least in the html field HTML is explicitly allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants